Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "wanrings as errors" settings from pyproject.toml in conda build #117

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

SimonHeybrock
Copy link
Member

This can otherwise break releases. Recent example: h5py minor version warnings in scipp/chexus release.

This can otherwise break releases. Recent example: h5py minor version
warnings in scipp/chexus release.
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, ok. Did you check that the package actually works? Or does h5py refuse to work when a bad hdf5 version is installed?

@SimonHeybrock
Copy link
Member Author

I didn't, but if minor versions are incompatible there is not much we can do, unless we want to pin the version for the release?

@jl-wynen
Copy link
Member

yes

@SimonHeybrock SimonHeybrock merged commit 6ab28e4 into main Dec 13, 2023
2 checks passed
@SimonHeybrock SimonHeybrock deleted the ignore-python-warnings-conda-build branch December 13, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants