Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify test dependencies in pyproject.toml #201

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

jokasimr
Copy link
Contributor

@jokasimr jokasimr commented Aug 23, 2024

Previously test dependencies had to be added both to basetest.in and to conda/meta.yaml.
That was a bit error prone. It's easy to forget updating conda test dependencies, and then things would crash next time the package was deployed.

This change makes test dependencies work similar to regular dependencies that we define in pyproject.yaml and then copy to meta.yaml and to base.in.

The advantage is we only need to write the test dependencies in one place.

@jokasimr jokasimr force-pushed the add-test-deps-to-pyproject branch from 027f89d to ad845ce Compare August 23, 2024 10:03
@jokasimr jokasimr force-pushed the add-test-deps-to-pyproject branch from 1a4a152 to f1f814f Compare August 23, 2024 11:02
@YooSunYoung YooSunYoung self-assigned this Aug 23, 2024
@jokasimr jokasimr merged commit bd9d844 into main Aug 23, 2024
2 checks passed
@jokasimr jokasimr deleted the add-test-deps-to-pyproject branch August 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants