Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scipp from pypi index instead of github url for nightlies #234

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Nov 22, 2024

suffix = "manylinux_2_17_x86_64.manylinux2014_x86_64.whl"
prefix = "scipp @ "
return prefix + "-".join([base, version, version, suffix])
return (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks fine. So I guess we also need to start uploading nightly wheels in the index for the other packages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to but we can to keep things consistent :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, let's just start with scipp?

Copy link
Member

@nvaytet nvaytet Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we start with scipp.
But we need to put the others there as well so that the integration tests are running on latest nightly main, because at the moment, they are using latest released as we cannot install from github (ip address is getting throttled).

But yes, this is not for this PR.

return prefix + "-".join([base, version, version, suffix])
return (
"scipp\n"
"--index-url=https://pypi.anaconda.org/scipp-nightly-wheels/simple/\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a comment just to say that the order of the indexes is important here?

@MridulS MridulS enabled auto-merge December 3, 2024 07:01
prefix = "scipp @ "
return prefix + "-".join([base, version, version, suffix])
# With the standard pip resolver index-url takes precedence over
# extra-index-url but with uv it's reversed, so if we move to tox-uv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but with uv it's reversed

🙄

@MridulS MridulS merged commit 49d29ec into scipp:main Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants