-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copier as dev requirement #96
Conversation
@@ -10,3 +10,6 @@ sphinx-autodoc-typehints | |||
sphinx-copybutton | |||
sphinx-design | |||
platformdirs<4 # temporary until virtualenv has release with support for this | |||
# Temporary until questionary (dep of copier) updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this related to copier? Because you may render the template in the same env as running tox -e deps
? Why does the result of the latter depend on an installed version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip-compile-multi requires that all envs resolve to the same versions of all packages.
Without this pin, In dev.txt, we get the pinned version here because of copier. In docs.txt we get a newer version because ipython depends on it but does not exclude the newer version. So pip-compile-multi fails to resolve.
This is the same issue as with platformdirs in the line above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I feel having a dev and affect the pinning is actually a problem: We may end up in situations where a dev-only dependency causes the use of a certain version, hiding problems in CI.
Can we avoid this? Should dev.in
be moved elsewhere? Can it be handled using a different call to pip-compile-multi
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial intention was to make dev reflect the other envs to make it easier to work with. So it should have the same versions.
I'm not sure this really is an issue. We anyway don't see the exact same versions in the test/docs/etc envs as in production.
32c5036
to
7f578ef
Compare
No description provided.