Opacity from beamdata #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty from beam-data fit to data
src/ess/polarization/base.py
Outdated
Comment on lines
311
to
316
| def Intensity_direct_beam_cell(time, opacity_cell): | ||
| return direct_beam*transmission_empty_glass*sc.exp(-opacity_cell) | ||
|
|
||
| popt, pcov = sc.curve_fit(['time'], reduce_dims = ['wavelength'], Intensity_direct_beam_cell, direct_beam_cell) | ||
| # Q: correct to use 'time' on x-axis? | ||
| # expected output: popt = opacity = single parameter for each cell, wavelength independent |
There was a problem hiding this comment.
I don't get how you plan to drop the wavelength dependence from the data / equations. The direct beam data is wavelength dependent, so I thought this must be taken into account in the fit function. Can you write this down clearly "on paper" (i.e., as part of #16) before moving to implementation?
|
Superseded by #27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the opacity as input for the 3He-polarization. Here the opacity is fit to the equation given by beamdata measurements. Using reduce_dims[wavelength] should (correct?) fit one value of opacity to all I(lambda).