Treat value as one of fields. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
force-pushed
the
handle-value-setter
branch
from
3507b6e to
8970630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
I came to a conclusion that
valueshould also be treated as one offieldsto avoid handling too many cases and have consistent structure of the widget state dictionary.All additional states are also considered as
fields, for exampleopted-outflag in theOptionalWidgetorenabledflag in theSwitchWidget.I thought about just setting 'value' to
NoneforOptionalWidget, but then we can't save the wrapped widget state so I just made an additional flag so that the wrapped widget states can be extended.