fix: remove non-finite values #101
Conversation
| # Make the Q range cover a larger interval than the experiment is sensitive to. | ||
| # This let's us test the non-covered regions are filtered from the ORSO data. | ||
| amor_pipeline[QBins] = sc.geomspace( | ||
| dim="Q", start=0.005, stop=0.15, num=391, unit="1/angstrom" | ||
| ) |
There was a problem hiding this comment.
Would be nicer to put this in a separate test, instead of having one "let us test every aspect" one?
There was a problem hiding this comment.
Yeah I agree. But that would require re-running the pipeline again, making the tests slower.
So for that reason I opted for making it part of the test for the ORSO output instead.
There was a problem hiding this comment.
Since we both agree, maybe we can live with the slower tests? Alternatively, write a unit test for just this function, without running the full pipeline?
There was a problem hiding this comment.
Since we both agree, maybe we can live with the slower tests?
That's a weird way of putting it. I agreed about the aspect you brought up. But taking into account the drawback mentioned I opted for another solution.
If you prefer a different trade-off, for example having slower but more well separated tests, we can do that instead.
Fixes #100
Draft because needs test