Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make namespace package #113

Merged
merged 10 commits into from
Mar 11, 2024
Merged

Make namespace package #113

merged 10 commits into from
Mar 11, 2024

Conversation

nvaytet
Copy link
Member

@nvaytet nvaytet commented Mar 7, 2024

Fixes #87

Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ready to drop the support for installing esssans and old ess in the same env?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does isissans need to be a separate package? Doesn't it make more sense to have ess.sans.isis? The isis stuff is temporary anyway, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I don't really know, I thought because it's temporary then maybe easier to pull it out of ess.sans?

As a side note, I named it isissans because I thought from ess import isis didn't make much sense, since it was just SANS-related stuff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I don't really know, I thought because it's temporary then maybe easier to pull it out of ess.sans?

Dunno. I'm fine with it either way.

As a side note, I named it isissans because I thought from ess import isis didn't make much sense, since it was just SANS-related stuff.

👍

@nvaytet
Copy link
Member Author

nvaytet commented Mar 7, 2024

Are we ready to drop the support for installing esssans and old ess in the same env?

I think so? I don't think anyone is using sans and other old ess things at the same time.
I also don't think there is anything left in the old repo we don't have in esssans.

@nvaytet nvaytet merged commit 3fdad66 into main Mar 11, 2024
3 checks passed
@nvaytet nvaytet deleted the namespace-package branch March 11, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to namespace package
2 participants