fix: add associated monitor workspace to data workspace #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ess/sans/types.py
Outdated
Comment on lines
356
to
357
| Period = NewType('Period', int) | ||
| """Period number.""" |
There was a problem hiding this comment.
Periods are an ISIS thing, this should only be defined in that submodule.
src/ess/isissans/mantidio.py
Outdated
| @@ -106,6 +115,13 @@ def load_run(filename: FilePath[Filename[RunType]]) -> DataWorkspace[RunType]: | |||
| else: | |||
| # Separate data and monitor workspaces | |||
| data_ws = loaded.OutputWorkspace | |||
| if isinstance(data_ws, _mantid_api.WorkspaceGroup): | |||
| if period is None: | |||
| raise ValueError('Needs period to know what section to load') | |||
There was a problem hiding this comment.
Could be more specific about which parameter needs to be set.
SimonHeybrock
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the ISISSans workflow able to handle files with periods.
Annika has such files where the data is separated into periods based on polarization settings.