Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: add pooch as test dependency in conda build #161

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

jokasimr
Copy link
Contributor

No description provided.

@jokasimr jokasimr requested a review from nvaytet August 23, 2024 08:01
@jokasimr jokasimr force-pushed the add-pooch-to-conda-test branch from 747678b to 45bde3c Compare August 23, 2024 11:28
@YooSunYoung
Copy link
Member

YooSunYoung commented Aug 23, 2024

import pytest
from ess import isissans, loki, sans
@pytest.mark.parametrize('pkg', [sans, loki, isissans])
def test_has_version(pkg):
assert hasattr(pkg, '__version__')

I guess we need to do 3 of them separately...?

or install pytest manually in the action.

@jokasimr
Copy link
Contributor Author

import pytest
from ess import isissans, loki, sans
@pytest.mark.parametrize('pkg', [sans, loki, isissans])
def test_has_version(pkg):
assert hasattr(pkg, '__version__')

I guess we need to do 3 of them separately...?

or install pytest manually in the action.

Three separately sounds like a good solution

@jokasimr jokasimr force-pushed the add-pooch-to-conda-test branch from ddc4d61 to 4af8120 Compare August 23, 2024 12:07
@jokasimr jokasimr merged commit dde89ff into main Aug 23, 2024
4 checks passed
@jokasimr jokasimr deleted the add-pooch-to-conda-test branch August 23, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants