Detect missing typehint early #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| kwargs = {name: hints[name] for name in signature.kwonlyargs} | ||
| except KeyError: | ||
| raise ValueError( | ||
| f'Provider {provider} lacks type-hint for arguments.' |
There was a problem hiding this comment.
Suggested change
| f'Provider {provider} lacks type-hint for arguments.' | |
| f'Provider {provider} lacks type-hint for arguments or return value.' |
There was a problem hiding this comment.
No, that is handled separately
Comment on lines
-178
to
+180
| args = {name: hints[name] for name in signature.args} | ||
| kwargs = {name: hints[name] for name in signature.kwonlyargs} | ||
| try: | ||
| args = {name: hints[name] for name in signature.args} | ||
| kwargs = {name: hints[name] for name in signature.kwonlyargs} |
There was a problem hiding this comment.
So why did this not raise before? This looks the same to me (apart from a better exception message)?
There was a problem hiding this comment.
Correct. When I initially said
It pushes the detection forward to pipeline.get. But not to the constructor.
I hadn't implemented the Provider class yet. But since I implemented it, the missing type hint was already detected during Pipeline construction.
So yes, this PR only improves the error message.
Closed
SimonHeybrock
approved these changes
Feb 8, 2024
SimonHeybrock
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115