Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recursion and allow building cyclic graphs #19

Merged
merged 7 commits into from
Jul 25, 2023
Merged

Avoid recursion and allow building cyclic graphs #19

merged 7 commits into from
Jul 25, 2023

Conversation

SimonHeybrock
Copy link
Member

  • Avoid recursion. Not sure we ever get to graphs of a size where this would matter, but still.
  • Allow building graphs with cycles. Main motivation was to be able to visualize them, which could be valuable for debugging.

Base automatically changed from tests to main July 25, 2023 10:07
@SimonHeybrock SimonHeybrock merged commit f250f4e into main Jul 25, 2023
@SimonHeybrock SimonHeybrock deleted the no-recursion branch July 25, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YooSunYoung YooSunYoung YooSunYoung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonHeybrock @YooSunYoung