Better parametrized domain type #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeybrock
commented
Jul 25, 2023
| ... | ||
|
|
||
| A[Param1](1.5) | ||
| A[Param1]('abc') # type: ignore[arg-type] |
There was a problem hiding this comment.
Note that all tests in this file pass at runtime. mypy complains if we remove any of the type: ignore comments, but also complains if we put too many, since our config ensures that unused ignore comments are not allowed.
YooSunYoung
reviewed
Jul 25, 2023
YooSunYoung
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
Scopeto take the aliased type as a second parameter. This is required for detecting more issues viamypy.I could not find a way of automatically also inheriting from this class, so now we have to specify this twice. In practice we may often reuse the same
Scopesubclass many times (seeArrayTexample test), so this is hopefully not too much overhead.