Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use str repr for param table html repr when __name__ does not exist #45

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Use str repr for param table html repr when __name__ does not exist #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1690d6
use str repr for param table html repr when __name__ does not exist
nvaytet Aug 31, 2023
344a172
improve string reprs
nvaytet Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sciline/param_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,15 @@ def __len__(self) -> int:
return self._columns.__len__()

def __repr__(self) -> str:
return f"ParamTable(row_dim={self.row_dim}, columns={self._columns})"
return f"ParamTable(row_dim={self.row_dim.__name__}, columns={self._columns})"

def _repr_html_(self) -> str:
return (
f"<table><tr><th>{self.row_dim.__name__}</th>"
+ "".join(f"<th>{k.__name__}</th>" for k in self._columns.keys())
+ "".join(
f"<th>{getattr(k, '__name__', str(k).split('.')[-1])}</th>"
for k in self._columns.keys()
)
SimonHeybrock marked this conversation as resolved.
Show resolved Hide resolved
+ "</tr>"
+ "".join(
f"<tr><td>{idx}</td>" + "".join(f"<td>{v}</td>" for v in row) + "</tr>"
Expand Down
2 changes: 1 addition & 1 deletion src/sciline/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def __getitem__(self, key: Key) -> Value:
return self._map[key]

def __repr__(self) -> str:
return f"Series(row_dim={self.row_dim}, {self._map})"
return f"Series(row_dim={self.row_dim.__name__}, {self._map})"

def _repr_html_(self) -> str:
return (
Expand Down