feat: prioritize specialized providers over generic #77
Conversation
src/sciline/pipeline.py
Outdated
| if _is_compatible_type_tuple(requested, args) | ||
| ), | ||
| ) | ||
| matches = match_groups[min(match_groups.keys(), default=0)] |
There was a problem hiding this comment.
I found the use of defaultdict a bit confusing when reading this.
There was a problem hiding this comment.
The use of defaultdict comes from the groupby, for all intents and purposes it could have been a regular dict. In line 473 the providers with the fewest TypeVar arguments are passed on and the rest are dropped.
There was a problem hiding this comment.
whole bunch of tests missing for generics with multiple typevars and various partial specializations.
Yeah you're right. I'll fix that.
There was a problem hiding this comment.
My point is: If there are no matches, then you would get a KeyError here, unless you use defaultdict, which is the wrong exception type, right?
There was a problem hiding this comment.
Yeah okay I see, the logic should be made clearer there, it's just a fluke that we don't get a bug because match_groups happens to be defaultdict.
jokasimr
force-pushed
the
specialized-providers
branch
from
c84ad58 to
fb43e78
Compare
Fixes #69
A type tuple
ais considered more "special" than a type tuplebif the number ofTypeVars inais lower than inb.