-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copier and dependencies #485
Conversation
@@ -0,0 +1,83 @@ | |||
from typing import Any, NewType, Optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what the code in this file is doing? How differently do things render in the docs when this is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- tox==4.11.3 | ||
|
||
# docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were the docs deps removed? Is it because we no longer want to build the docs on py39?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't build on 3.9 because there is no compatible mantid version. So I simplified the file
scippneutron | ||
pytest | ||
commands = pytest | ||
|
||
[testenv:static] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. We have both ci.yml
and pr_and_main.yml
. Must have been a messed up merge at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was intentional, to have builds with Mantid (using conda) as well as the common setup (no Mantid).
Co-authored-by: Neil Vaytet <[email protected]>
No description provided.