Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copier and dependencies #485

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Update copier and dependencies #485

merged 6 commits into from
Jan 24, 2024

Conversation

jl-wynen
Copy link
Member

No description provided.

@@ -0,0 +1,83 @@
from typing import Any, NewType, Optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what the code in this file is doing? How differently do things render in the docs when this is used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- tox==4.11.3

# docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were the docs deps removed? Is it because we no longer want to build the docs on py39?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't build on 3.9 because there is no compatible mantid version. So I simplified the file

scippneutron
pytest
commands = pytest

[testenv:static]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this line

Are we running too many checks? There seems to be a mix of ubuntu versions, and python versions? Do we still have old CI workflows running alongside new ones?
Screenshot at 2024-01-24 13-14-03
Screenshot at 2024-01-24 13-14-51

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. We have both ci.yml and pr_and_main.yml. Must have been a messed up merge at some point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was intentional, to have builds with Mantid (using conda) as well as the common setup (no Mantid).

Co-authored-by: Neil Vaytet <[email protected]>
@jl-wynen jl-wynen merged commit 9dd1926 into main Jan 24, 2024
6 checks passed
@jl-wynen jl-wynen deleted the update-deps branch January 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants