Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when loading NXdata with NXlog signal #126

Merged
merged 6 commits into from
Apr 17, 2023
Merged

Fix exception when loading NXdata with NXlog signal #126

merged 6 commits into from
Apr 17, 2023

Conversation

SimonHeybrock
Copy link
Member

Also affected NXdata subclasses

jl-wynen
jl-wynen approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But see the 2nd part of #123 (comment)

@SimonHeybrock SimonHeybrock mentioned this pull request Apr 17, 2023
Merged
Base automatically changed from update-docs to main April 17, 2023 11:06
@SimonHeybrock SimonHeybrock requested a review from jl-wynen April 17, 2023 11:12
@SimonHeybrock SimonHeybrock merged commit c525c83 into main Apr 17, 2023
@SimonHeybrock SimonHeybrock deleted the fix-nxlog-data branch April 17, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jl-wynen jl-wynen Awaiting requested review from jl-wynen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonHeybrock @jl-wynen