Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] issue 204 by removing trailing forward slashes in string selectors #205

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

g5t
Copy link
Contributor

@g5t g5t commented Apr 23, 2024

One possible fix for #204 if any number of trailing forward slashes should not raise an error.

Fixes #204.

Copy link
Member

@SimonHeybrock SimonHeybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, look reasonable. Do you feel like adding a unit test? If not, we can take care of that.

@MridulS
Copy link
Member

MridulS commented Apr 23, 2024

The doc failure should be fixed by #207

@g5t
Copy link
Contributor Author

g5t commented Apr 23, 2024

I've added a unit test which will fail with a KeyError before my proposed fix.
It may be more-restrictive than necessary, since it only passes the assert if the same object is returned with and without a trailing forward slash in its path.

@SimonHeybrock SimonHeybrock enabled auto-merge April 24, 2024 03:07
Copy link
Member

@SimonHeybrock SimonHeybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimonHeybrock SimonHeybrock merged commit 02e43eb into scipp:main Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A trailing '/' in a file selector path raises a KeyError
3 participants