Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy more complete pre-commit config from scipp #90

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

SimonHeybrock
Copy link
Member

Only change is removed clang-format, and applied formatting.

Right now there is an issue from isort and yapf undoing each others changes. Move to black?

Only change is removed clang-format
Adding trailing-comma option does the trick
@SimonHeybrock SimonHeybrock marked this pull request as ready for review January 10, 2023 08:19
@SimonHeybrock
Copy link
Member Author

@jl-wynen I got around the isort/yapf conflict by configuring isort to include trailing commas.

@SimonHeybrock SimonHeybrock merged commit 579de48 into main Jan 10, 2023
@SimonHeybrock SimonHeybrock deleted the update-pre-commit-config branch January 10, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants