Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch more errors from NXtransformations #97

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Catch more errors from NXtransformations #97

merged 2 commits into from
Jan 30, 2023

Conversation

SimonHeybrock
Copy link
Member

Will need to make a bugfix release, since this broke scippneutron.

jl-wynen
jl-wynen approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help with these things in the future, can you make a page in the docs that explains what exceptions can be raised and what they mean? In particular, which exceptions trigger fallback loaders or other special behaviour.

@SimonHeybrock SimonHeybrock merged commit f5e6558 into main Jan 30, 2023
@SimonHeybrock SimonHeybrock deleted the fix-nxtransformations branch January 30, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jl-wynen jl-wynen jl-wynen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonHeybrock @jl-wynen