-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SCL globally without sourcing bashrc #35
Conversation
This will allow us to remove all `source .bashrc` lines from the downstream images.
FYI: The tests will fail for all those images without the change in sti-base. I'm testing all PR's manually using make test. |
@bparees @mnagy @rhcarvalho @soltysh @jhadvig guys, can I ask you to just double-check if I didn't miss something in all this copy & pasting? I ran Also I just want to make you aware of this change. This means that we no longer need to source Additionally I added SKIP_SQUASH=1 option for @hhorak can you please confirm that using BASH_ENV this way won't break anything? So far all our tests are passing (including the full examples we have in openshift org). |
LGTM |
LGTM, love the SKIP_SQUASH. |
I should probably put a fat warning to every .bashrc saying that you should NOT add more stuff there as it will be run everytime you execute the bash itself. This can be nasty and for example in sti-python we do the arbitrary user magic in that file. This magic will be execute everytime you run bash. We should probably move that into separate file and source it just in |
(warning added), got 2 lgtm, merging this. |
Enable SCL globally without sourcing bashrc
Nicely done @mfojtik ! |
This PR enables the SCL collections globally by using BASH_ENV to inject the
scl enable
to every/bin/bash
session.This require change to every image we have, so don't merge it on its own, this have to be merged together with other PR's I will link to this PR.