Skip to content

Commit

Permalink
Merge pull request #21 from mfojtik/bash-env
Browse files Browse the repository at this point in the history
Remove bashrc sourcing in STI scripts
  • Loading branch information
Michal Fojtik committed Jun 10, 2015
2 parents 588fce8 + 3497e9a commit aa61796
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
2 changes: 0 additions & 2 deletions 5.5/.sti/bin/assemble
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#!/bin/bash

source ./.bashrc

set -e

echo "---> Installing application source"
Expand Down
3 changes: 0 additions & 3 deletions 5.5/.sti/bin/run
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
#!/bin/bash

# For SCL enablement
source ./.bashrc

# Default php.ini configuration values, all taken
# from php defaults.
export ERROR_REPORTING=${ERROR_REPORTING:-E_ALL & ~E_NOTICE}
Expand Down
4 changes: 4 additions & 0 deletions 5.5/contrib/src/.bashrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
# IMPORTANT: Do not add more content to this file unless you know what you are
# doing. This file is sourced everytime the shell session is opened.
#
# This will make scl collection binaries work out of box.
unset BASH_ENV
source scl_source enable php55 httpd24
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ endif

.PHONY: build
build:
hack/build.sh $(OS) $(VERSION)
SKIP_SQUASH=$(SKIP_SQUASH) hack/build.sh $(OS) $(VERSION)


.PHONY: test
test:
TEST_MODE=true hack/build.sh $(OS) $(VERSION)
SKIP_SQUASH=1 TEST_MODE=true hack/build.sh $(OS) $(VERSION)
4 changes: 3 additions & 1 deletion hack/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ function docker_build {
fi

docker build -t ${TAG} . && trap - ERR
squash
[ -z "${SKIP_SQUASH}" ] && squash

return 0
}

if [ -z ${VERSION} ]; then
Expand Down

0 comments on commit aa61796

Please sign in to comment.