Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations are not detected during sgd diff commit 1 commit2 #940

Closed
pjha06 opened this issue Oct 23, 2024 · 6 comments
Closed

Translations are not detected during sgd diff commit 1 commit2 #940

pjha06 opened this issue Oct 23, 2024 · 6 comments
Assignees
Labels
bug Something isn't working reproduction steps needed Need reproduction steps to further with the analysis

Comments

@pjha06
Copy link

pjha06 commented Oct 23, 2024

| Changed en_US Translations force-app\main\default\translations\en_US.translation-meta.xml
| Changed es Translations force-app\main\default\translations\es.translation-meta.xml
| Changed fr Translations force-app\main\default\translations\fr.translation-meta.xml

i have retrieved above files from my org but in package creation step it does not detect this changes and creates below package.xml

62.0

@pjha06 pjha06 added the bug Something isn't working label Oct 23, 2024
@scolladon
Copy link
Owner

Hi @pjha06 !

Thanks for raising this issue and thanks for contributing in making this project better!

Could you help me reproduce on my machine please ?
We have a reproduction playground, you could fork it, create a branch, put in it the minimal information to reproduce the issue and share that with me if the instructions to reproduce it please ?

@scolladon scolladon added the reproduction steps needed Need reproduction steps to further with the analysis label Oct 23, 2024
@pjha06
Copy link
Author

pjha06 commented Oct 23, 2024 via email

@scolladon
Copy link
Owner

Hi @pjha06,

I have done a few test (add, modify existing, modify by adding, modify by removing, deleting) on the playground and it seems to be working on my side.
Could you check out the branch and run between each commit sf sgd source delta -f HEAD~1 -d and tell me the result ?

I'm using mac
with node v18.20.4
with npm 10.9.0
with git 2.47.0
with salesforce/cli 2.42.6
with sfdx-git-delta 5.49.0

@scolladon
Copy link
Owner

sf sgd:source:delta --from d20854011af913defd507982d3e833dd26e3317b --to "HEAD" --output deltas --generate-delta --source force-app

I think the issue is because the Translations are empty.
As there is nothing to deploy it is not listed nor copied.

The plugin is able to trim the Translations file to contains only what as changed between 2 revisions.
This way it allows for faster deployment of only what as really changed.
There are a few metadata type for which the metadata API behaves like this.

@pjha06
Copy link
Author

pjha06 commented Oct 23, 2024 via email

@scolladon
Copy link
Owner

No problem @pjha06 !
Happy to help.

Enjoy incremental deployment 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reproduction steps needed Need reproduction steps to further with the analysis
Projects
None yet
Development

No branches or pull requests

2 participants