-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations are not detected during sgd diff commit 1 commit2 #940
Comments
Hi @pjha06 ! Thanks for raising this issue and thanks for contributing in making this project better! Could you help me reproduce on my machine please ? |
Hi Sebastien ,
I created a fork
https://github.com/pjha06/sfdx-git-delta-reproduction-playground
Clone URl:
https://github.com/pjha06/sfdx-git-delta-reproduction-playground.git
and added few commits ,Please run below command to generate deltas:
sf sgd:source:delta --from d20854011af913defd507982d3e833dd26e3317b --to
"HEAD" --output deltas --generate-delta --source force-app
and see the package.xml under deltas folder.
Regards,
Prabhat Jha
…On Wed, Oct 23, 2024 at 1:08 PM Sebastien ***@***.***> wrote:
Hi @pjha06 <https://github.com/pjha06> !
Thanks for raising this issue and thanks for contributing in making this
project better!
Could you help me reproduce on my machine please ?
We have a reproduction playground
<https://github.com/scolladon/sfdx-git-delta-reproduction-playground>,
you could fork it, create a branch, put in it the minimal information to
reproduce the issue and share that with me if the instructions to reproduce
it please ?
—
Reply to this email directly, view it on GitHub
<#940 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZJARJAO6GYORDP5EN2GSTZ45HAPAVCNFSM6AAAAABQOCEZT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRGE3DCMRUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @pjha06, I have done a few test (add, modify existing, modify by adding, modify by removing, deleting) on the playground and it seems to be working on my side. I'm using mac |
I think the issue is because the Translations are empty. The plugin is able to trim the Translations file to contains only what as changed between 2 revisions. |
Hi Sebastien,
I understand its the issue with the retrieval as i added a file used by
you,its detected under package.xml.
Apology for your wasted time.
Regards,
Prabhat Jha
…On Wed, Oct 23, 2024 at 1:51 PM Sebastien ***@***.***> wrote:
Hi @pjha06 <https://github.com/pjha06>,
I have done a few test (add, modify existing, modify by adding, modify by
removing, deleting) on the playground
<https://github.com/scolladon/sfdx-git-delta-reproduction-playground/tree/issue/940>
and it seems to be working on my side.
Could you check out the branch and run between each commit sf sgd source
delta -f HEAD~1 -d and tell me the result ?
*I'm using mac with node v18.20.4 with npm 10.9.0 with git 2.47.0 with
salesforce/cli 2.42.6 with sfdx-git-delta 5.49.0*
—
Reply to this email directly, view it on GitHub
<#940 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZJARMNQP743DTSYRIU4IDZ45MBFAVCNFSM6AAAAABQOCEZT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRGI3DONBSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No problem @pjha06 ! Enjoy incremental deployment 🚀 |
| Changed en_US Translations force-app\main\default\translations\en_US.translation-meta.xml
| Changed es Translations force-app\main\default\translations\es.translation-meta.xml
| Changed fr Translations force-app\main\default\translations\fr.translation-meta.xml
i have retrieved above files from my org but in package creation step it does not detect this changes and creates below package.xml
62.0
The text was updated successfully, but these errors were encountered: