Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend metadata content pruning to more eligible types #533

Merged
merged 56 commits into from
Apr 21, 2023
Merged
Show file tree
Hide file tree
Changes from 50 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
6b57899
refactor: simplify implementation
scolladon Mar 19, 2023
f6691d4
refactor: use xmlName instead of directoryName
scolladon Mar 19, 2023
1a8273f
test: add attribut filtering spec
scolladon Mar 25, 2023
50d1368
feat: add InFile type
scolladon Mar 25, 2023
057c96a
refactor: make integration test more integrated
scolladon Mar 25, 2023
0566a22
refactor: more functional implementation
scolladon Mar 25, 2023
28f0df0
feat: add key identifier information in metadata
scolladon Mar 25, 2023
5b205d0
refactor: remove duplicate name
scolladon Mar 25, 2023
4f189ff
feat: add package exclusion
scolladon Mar 25, 2023
734213f
feat: add value set translations
scolladon Mar 25, 2023
522bdf3
feat: add profile and translation with pruneOnly
scolladon Mar 25, 2023
b5a8052
test: add Profile and Translations integration
scolladon Mar 25, 2023
7eaa18a
fix: keep untrackable element infile
scolladon Mar 26, 2023
cbd1133
refactor: rename inTranslation => ObjectTranslation
scolladon Mar 26, 2023
48c7917
refactor: extract inFileConfiguration
scolladon Mar 26, 2023
f67a67f
feat: write file once
scolladon Mar 26, 2023
2894b2e
feat: add objectTranslation pruning implementation
scolladon Mar 26, 2023
17ee09d
refactor: use Map instead of {}
scolladon Mar 26, 2023
a00db0a
refactor: fail safe readPathFromGit
scolladon Mar 26, 2023
3255adf
test: improve metadaDiff spec in corner cases
scolladon Mar 26, 2023
3e00603
feat: restructure metadata file
scolladon Mar 26, 2023
1ef675b
feat: propagate metadata structure changes
scolladon Mar 26, 2023
e41a869
fix: make code using metadata fail safe
scolladon Mar 26, 2023
9c4bb90
test: improve spec coverage
scolladon Mar 26, 2023
9aebeee
docs: add metadata API philosophical questions
scolladon Mar 26, 2023
6034d78
test: customObjectTranslation integration tests
scolladon Mar 26, 2023
88e90d1
build: upgrade dependencies
scolladon Mar 26, 2023
129ca30
refactor: migrate getWaveMetadata type to metadataManager
scolladon Mar 26, 2023
c019352
fix: multiple write in output
scolladon Mar 27, 2023
2e14754
build: remove deprecated mocha file
scolladon Mar 30, 2023
24dc714
Merge branch 'main' into feat/more-infile-metadata-handling
scolladon Mar 30, 2023
2cdb82f
Merge branch 'main' into feat/more-infile-metadata-handling
scolladon Mar 31, 2023
22c1fc0
build: add oclif/core dependency
scolladon Mar 31, 2023
fd96d6e
refactor: use xmlName for translationProcessor as well
scolladon Apr 1, 2023
2e60a6a
Merge branch 'main' into feat/more-infile-metadata-handling
scolladon Apr 4, 2023
190b335
fix: metadataManager cache
scolladon Apr 4, 2023
9e90d33
build: upgrade dependencies
scolladon Apr 4, 2023
5aae14e
Merge branch 'main' into feat/more-infile-metadata-handling
scolladon Apr 4, 2023
ee27c3d
ci: add E2E test when releasing
scolladon Apr 4, 2023
243616a
build: upgrade dependencies
scolladon Apr 11, 2023
767a99d
fix: flowTranslationProcessor with new type identifier
scolladon Apr 15, 2023
2cbdba4
fix: remove workflowaction and knowledgepublish inFile changes
scolladon Apr 15, 2023
e7aaf84
ci: add concurrency management
scolladon Apr 15, 2023
ba3f999
fix: remove old api version metadata
scolladon Apr 15, 2023
537f70d
fix: remove layout assignment diff
scolladon Apr 15, 2023
a7ed09d
build: upgrade dependencies
scolladon Apr 15, 2023
924f8b0
Merge branch 'main' into feat/more-infile-metadata-handling
scolladon Apr 17, 2023
2e3aa8b
fix: megalinter issue on main github workflow
scolladon Apr 17, 2023
3e33648
fix: megalinter spellchecks issue
scolladon Apr 17, 2023
d2f48cb
ci: remove source-lint for megalinter
scolladon Apr 17, 2023
9c0c4c3
refactor: extract xml2json conversion
scolladon Apr 19, 2023
826ab30
feat: append flowDefinition to scoped Translations
scolladon Apr 19, 2023
4b8eb32
build: upgrade dependencies
scolladon Apr 20, 2023
d617635
fix: code complexity
scolladon Apr 20, 2023
e90edc7
refactor: split responsability in sub methods
scolladon Apr 20, 2023
5fd7f50
refactor: create LWC handler to segregate `isProcessable` algorithm
scolladon Apr 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/linters/.cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"flowtype",
"forceignore",
"forceinclude",
"friendlyname",
"geodata",
"iframe",
"ignorewarnings",
Expand Down
18 changes: 18 additions & 0 deletions .github/workflows/on-main-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,18 @@ jobs:
needs: [prepare-release, release]
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v3
with:
ref: 'e2e/head'
fetch-depth: 0

- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 16
registry-url: https://registry.npmjs.org/

- name: Install sfdx-cli
run: npm install -g sfdx-cli

Expand All @@ -62,3 +74,9 @@ jobs:

- name: Test new plugin version
run: sfdx sgd:source:delta --help

- name: E2E Tests
working-directory: ./e2e
run: |
yarn
yarn test:e2e
23 changes: 1 addition & 22 deletions .github/workflows/on-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,28 +61,7 @@ jobs:
run: yarn audit
continue-on-error: true

source-lint:
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v3

- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 16
registry-url: https://registry.npmjs.org/

- name: Setup node
uses: ./.github/actions/install

- name: Lint sources
uses: wearerequired/lint-action@v2
with:
eslint: true

megalinter:
name: MegaLinter
runs-on: ubuntu-latest
steps:
# Git Checkout
Expand Down Expand Up @@ -143,7 +122,7 @@ jobs:
secrets: inherit

e2e-check:
needs: [build, source-lint]
needs: [build, megalinter]
strategy:
matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ OPTIONS
this command invocation
```

_See code: [src/commands/sgd/source/delta.ts](https://github.com/scolladon/sfdx-git-delta/blob/v5.13.3/src/commands/sgd/source/delta.ts)_
_See code: [src/commands/sgd/source/delta.ts](https://github.com/scolladon/sfdx-git-delta/blob/main/src/commands/sgd/source/delta.ts)_
<!-- commandsstop -->

### Windows users
Expand Down
6 changes: 3 additions & 3 deletions __tests__/integration/delta.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ describe(`test if the appli`, () => {
generateDelta: true,
})

expect(work.diffs.package.get('fields')).toContain('Account.changed')
expect(work.diffs.destructiveChanges.get('fields')).not.toContain(
expect(work.diffs.package.get('CustomField')).toContain('Account.changed')
expect(work.diffs.destructiveChanges.get('CustomField')).not.toContain(
'Account.changed'
)
})
Expand All @@ -133,6 +133,6 @@ describe(`test if the appli`, () => {
apiVersion: '46',
generateDelta: true,
})
expect(work.diffs.package.get('rules')).toContain('EU.France')
expect(work.diffs.package.get('Territory2Rule')).toContain('EU.France')
})
})
Loading