feat: add a new command to filter the content of Profile and Pset based on multiple package.xml #90
Conversation
| const XML_PARSER_OPTION = { | ||
| ignoreAttributes: false, | ||
| ignoreNameSpace: false, | ||
| arrayMode: true, |
There was a problem hiding this comment.
This can fix some potential issue in very edge case
scolladon
force-pushed
the
master
branch
6 times, most recently
from
220871b to
ae44c14
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| protected static requiresProject = true | ||
|
|
||
| public async run(): Promise<AnyJson> { |
There was a problem hiding this comment.
Function run has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Also add arrayMode:true in case of only one element child
|
|
||
| protected static requiresProject = true | ||
|
|
||
| public async run(): Promise<AnyJson> { |
There was a problem hiding this comment.
Function run has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 633 633
=========================================
Hits 633 633 Continue to review full report at Codecov.
|
scolladon
changed the title
|
|
||
| protected static requiresProject = true | ||
|
|
||
| public async run(): Promise<AnyJson> { |
There was a problem hiding this comment.
Function run has 86 lines of code (exceeds 25 allowed). Consider refactoring.
|
Code Climate has analyzed commit 4df207a and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
What does this pull request contains? Explain your changes.
Explain your changes
Add a new command to have the ability to filter the content of a Profile and a Permission Set based on the content of multiple package.xml
The command takes a list of path of package.xml
The command takes a list of path where profile and permissionset should be located (recursively) to apply the filtering into them.
The command takes a list of userPermissions to keep. The actual behaviour is to remove every user permission not present in this white list.
Does this close any currently open issues?
No issue related
Any particular element to being able to test locally
To test it you have to call the command
sfdx sgd:source:ppset -hAny other comments?
This is WIP, no test case written yet and no traction from the community for this use case.
The current state of the code written is not acceptable
Where has this been tested?
Operating System: Darwin Kernel Version 18.7.0
Yarn version: 1.22.10
Node version: v15.6.0
sgd version: 4.1.0
git version: 2.30.0