Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/update savon #21

Closed

Conversation

michael-harrison
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 99.685% when pulling 156c2da on michael-harrison:hotfix/update_savon into 79fefd8 on scotdalton:master.

@barnabyalter
Copy link
Collaborator

@michael-harrison forked and tracking NYULibraries#2

@coveralls
Copy link

coveralls commented Dec 7, 2017

Coverage Status

Coverage decreased (-2.06%) to 97.684% when pulling a7242a8 on michael-harrison:hotfix/update_savon into 79fefd8 on scotdalton:master.

@michael-harrison
Copy link
Author

@barnabyalter just a note on the latest commit. We have yet more nokogiri vulnerabilities (really libxml2 and libxslt vulnerabilities). I've had to add a horrible hack in Gemfile to allow the use of my PR for the fix on the savon. It'll be removed once they merge my PR. So merging of this PR is not advised until the savon PR is merged.

@barnabyalter
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants