Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorthand hex codes #1

Closed
stephenway opened this issue Oct 21, 2015 · 3 comments
Closed

Shorthand hex codes #1

stephenway opened this issue Oct 21, 2015 · 3 comments

Comments

@stephenway
Copy link
Contributor

Looks like testing
t.deepEqual(hexToRgb('#fff'), [255,255,255], 'white converted with hash');
does not pass, it is a common use case, how would this get fixed?

Thanks
@scottcorgan
Copy link
Owner

Can you open a PR with a failing test?

scottcorgan added a commit that referenced this issue Oct 22, 2015
@scottcorgan
Merge branch 'pr/2'
68bdd22 
* pr/2:
  expand shorthand hex to 6-digit hex. Fixes #1
  Update test.js
@scottcorgan
Copy link
Owner

Good find. Published as 1.0.1

@stephenway
Copy link
Contributor Author

Thanks for the quick turn around @scottcorgan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenway @scottcorgan