Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for EF 6.3, targeting net45 and netstandard2.1 #101

Closed
jtheisen opened this issue Oct 2, 2019 · 13 comments
Closed

Support for EF 6.3, targeting net45 and netstandard2.1 #101

jtheisen opened this issue Oct 2, 2019 · 13 comments
Labels

Comments

@jtheisen
Copy link

jtheisen commented Oct 2, 2019

The new version of EntityFramework 6.3 has an additional target, netstandard2.1, allowing it to be used with .NET Core 3.

I would assume that, for LINQKit EF6's incarnation, to support that new target also, it's "only" a package management issue rather than requiring any code changes.

@StefH
Copy link
Collaborator

StefH commented Oct 2, 2019

Seems reasonable. I will investigate if LinqKit and LinqKit.EntityFramework can also Target netstandard 2.1 + EF 6.3

StefH added a commit that referenced this issue Oct 2, 2019
@StefH
Copy link
Collaborator

StefH commented Oct 3, 2019

I can upload a preview version to MyGet so that you can test, would that help?

@jtheisen
Copy link
Author

jtheisen commented Oct 3, 2019

It's not extremely pressing in my case, but if you give me a link I'll try it out, thanks!

@ynauls
Copy link

ynauls commented Oct 4, 2019

any updates? looking for .netstandard2.1 support

@jtheisen
Copy link
Author

jtheisen commented Oct 4, 2019

Btw, I'm not sure if LINQKit.Core needs a new release at all. I think it already has netstandard2.0 as a target. Only the EntityFramework package (LINQKit.EntityFramework) hasn't, and there it needs to be 2.1 as that is the only version of netstandard that the new EF is targeting (for reasons unknown to me).

@StefH
Copy link
Collaborator

StefH commented Oct 4, 2019

@ynauls
1.1.17-preview-01 is available for testing at MyGet : https://www.myget.org/F/linqkit/api/v3/index.json

@ynauls
Copy link

ynauls commented Oct 4, 2019

@StefH, I needed this to upgrade to EF 3, I was getting the same error described here #100 by @brunosantosrhsenso. Using 1.1.17-preview, I get get past that error, but now I getting the same error described here #100 by @joshmouch

@StefH
Copy link
Collaborator

StefH commented Oct 4, 2019

I need to update the code because ef3 now supports real async enumerable.

@StefH
Copy link
Collaborator

StefH commented Oct 5, 2019

@ynauls
New preview is uploaded : LinqKit 1.1.17-preview-02 which works with EFCore 3.

Please test.

@ynauls
Copy link

ynauls commented Oct 7, 2019

@StefH, LinqKit 1.1.17-preview-02 looks good on initial pass. Will keep testing.

@ynauls
Copy link

ynauls commented Oct 23, 2019

@StefH, when can we expect 1.1.17 on NuGet?

@StefH
Copy link
Collaborator

StefH commented Oct 23, 2019

I'm waiting for verification on this one also:#102

Once that's correct, I'll create a NuGet.

@StefH StefH added the feature label Nov 26, 2019
@StefH
Copy link
Collaborator

StefH commented Nov 26, 2019

#103

@StefH StefH closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants