Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotnet core rc2 support and split into multiple versions/flavors #33

Merged
merged 4 commits into from
Jun 20, 2016
Merged

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jun 18, 2016

This pull request is to convert this project into the new dotnet rc2 project structure which adds support for more frameworks like NetStandard 1.3

Also in relation to this question : #28 , I did create 3 projects:

  1. LinqKit : the original code but this will compile from NET 3.5 until NetStandard 1.3, and has no dependency on EntityFramework.
  2. LinqKit.EntityFramework : this also based on your original code, but this one supports NET 4.5 until 4.6.1 and includes a dependency to EntityFramework 6.1.3
  3. LinqKit.Microsoft.EntityFrameworkCore : this also based on your original code, but this one supports NET 4.5.1 until NetStandard 1.3 and includes a dependency to Microsoft.EntityFrameworkCore 1.0.0-rc2-final

So can you please accept this PR so that your very handy project can be used in multiple ways, and can support more frameworks and versions from EF?

Note that for last two packages I've also created a NuGet, however, if you accept this PR, and upload a new LinqKit based on my first project (with correct version), I can transfer ownership from these twp packages to you.

(I also saw that @dopare copied this whole project and started a new at https://github.com/dopare/LinqKit.Core which is also available on NuGet, so maybe we can also merge something in that erea)

@Thorium
Copy link
Collaborator

Thorium commented Jun 20, 2016

Thanks!

@Thorium Thorium merged commit f31d287 into scottksmith95:master Jun 20, 2016
@Thorium
Copy link
Collaborator

Thorium commented Jun 20, 2016

The old build fails after merge: https://ci.appveyor.com/project/Thorium/linqkit/build/1.0.15

@StefH StefH mentioned this pull request Jun 26, 2016
@StefH StefH mentioned this pull request Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants