Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented ExpressionStarter<T> to eliminate the default 1=0 or 1=1 stub expressions #42

Merged
merged 7 commits into from
Jul 28, 2016

Conversation

rhyous
Copy link
Contributor

@rhyous rhyous commented Jul 21, 2016

See comments from here:
#30

@StefH
Copy link
Collaborator

StefH commented Jul 21, 2016

Quick question ; is the 'Extend' method also gone?

@rhyous
Copy link
Contributor Author

rhyous commented Jul 22, 2016

I don't see it. Perhaps I removed too much?
I removed the enum and the methods that use it.
Do you want it back?
I can easily put the extend method back before you accept the pull request if you want.

@StefH
Copy link
Collaborator

StefH commented Jul 22, 2016

Yes please put that one back.

@rhyous
Copy link
Contributor Author

rhyous commented Jul 25, 2016

I put it back. I didn't see any unit tests specific to that method. But all Unit Tests are still passing after restoring that method.

@rhyous
Copy link
Contributor Author

rhyous commented Jul 27, 2016

I updated the readme and added the Extend extension method to ExpressionStarter too.

@StefH
Copy link
Collaborator

StefH commented Jul 27, 2016

Thanks.

I'll merge all changes into the 'development' branch.

StefH added a commit that referenced this pull request Jul 27, 2016
@StefH
Copy link
Collaborator

StefH commented Jul 27, 2016

Merged into development branch, please review. If it's all correct, I'll merge to master and create a new NuGet.

@rhyous
Copy link
Contributor Author

rhyous commented Jul 27, 2016

I checked out the development branch. I think there is an issue with the DbAsyncTests breaking the build.

The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?) LinqKit.Microsoft.EntityFrameworkCore.Tests..NETCoreApp,Version=v1.0

It looks like a using statement is comment out and it shouldn't be?

Line 7 //using LinqKit.EntityFramework.Tests;

Once I uncommented that, I had to change a few variables called db to _db. Then it all builds.

I ran the Unit Tests and it all passes. So update DbAsyncTests and it will be good to go. I had to modify four lines.

line 7  using LinqKit.EntityFramework.Tests;
line 29            _db = new TestContext(builder.Options);
line 30            _db.Database.EnsureCreated();
line 49            _db.Database.EnsureDeleted();

@StefH StefH added the feature label Jul 27, 2016
@StefH StefH self-assigned this Jul 27, 2016
@StefH
Copy link
Collaborator

StefH commented Jul 27, 2016

Fix in dev.

@StefH StefH merged commit a7158e9 into scottksmith95:master Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants