-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented ExpressionStarter<T> to eliminate the default 1=0 or 1=1 stub expressions #42
Conversation
…false in case the reall expression is null.
Quick question ; is the 'Extend' method also gone? |
I don't see it. Perhaps I removed too much? |
Yes please put that one back. |
I put it back. I didn't see any unit tests specific to that method. But all Unit Tests are still passing after restoring that method. |
I updated the readme and added the Extend extension method to ExpressionStarter too. |
Thanks. I'll merge all changes into the 'development' branch. |
Merged into development branch, please review. If it's all correct, I'll merge to master and create a new NuGet. |
I checked out the development branch. I think there is an issue with the DbAsyncTests breaking the build. The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?) LinqKit.Microsoft.EntityFrameworkCore.Tests..NETCoreApp,Version=v1.0 It looks like a using statement is comment out and it shouldn't be? Line 7 //using LinqKit.EntityFramework.Tests; Once I uncommented that, I had to change a few variables called I ran the Unit Tests and it all passes. So update DbAsyncTests and it will be good to go. I had to modify four lines.
|
Fix in dev. |
See comments from here:
#30