forked from OpenLiberty/ci.maven
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
cdfad8f
commit ad06d0a
Showing
1 changed file
with
28 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,32 @@ | ||
# Contributing to Liberty Maven Plug-in | ||
|
||
We welcome contributions but please follow these [guidelines](https://github.com/WASdev/wasdev.github.io/blob/master/CONTRIBUTING.md). | ||
Anyone can contribute to the Liberty Maven Plug-in project and we welcome your contributions! | ||
|
||
[Issue tracker.](https://github.com/WASdev/ci.maven/issues) | ||
There are multiple ways to contribute: report bugs, fix bugs, contribute code, improve upon documentation, etc. You must follow these guidelines: | ||
* [Raising issues](#raising-issues) | ||
* [Contributor License Agreement](#contributor-license-agreement) | ||
* [Coding Standards](#coding-standards) | ||
|
||
## Raising issues | ||
Please raise any bug reports on the [Liberty Maven Plug-in project repository's GitHub issue tracker](https://github.com/OpenLiberty/ci.maven/issues). Be sure to search the list to see if your issue has already been raised. | ||
|
||
A good bug report is one that makes it easy for everyone to understand what you were trying to do and what went wrong. Provide as much context as possible so we can try to recreate the issue. | ||
|
||
## Contributor License Agreement | ||
If you are contributing code changes via a pull request for anything except trivial changes, you must signoff on the [Individual Contributor License Agreement](https://github.com/OpenLiberty/open-liberty/blob/master/cla/open-liberty-cla-individual.pdf) If you are doing this as part of your job you may also wish to get your employer to sign a CCLA [Corporate Contributor License Agreement](https://github.com/OpenLiberty/open-liberty/blob/master/cla/open-liberty-cla-corporate.pdf). Instructions how to sign and submit these agreements are located at the top of each document. Trivial changes such as Typos, redundant spaces, minor formatting and spelling errors will be labeled as "CLA trivial", and don't require a signed CLA for consideration. | ||
|
||
After we obtain the signed CLA, you are welcome to open a pull request, and the team will be notified for review. We ask you follow these steps through the submission process. | ||
1. Ensure you run a passing local maven build explained in the [README](https://github.com/OpenLiberty/ci.maven/blob/master/README.md#build) before opening a PR. | ||
2. Open PR's against the "master" branch. | ||
3. A label will be added "CLA signed" or "CLA trivial" depending on the nature of the change. | ||
4. A team of "reviewers" will be notified, will perform a review, and if approved will merge the PR. | ||
5. If a reviewer has comments, questions or suggestions, those must be addressed before the PR is approved. | ||
|
||
|
||
## Coding Standards | ||
Please ensure you follow the coding standards used throughout the existing code base. Some basic rules include: | ||
* All files must have a Copyright including the Apache license in the header. | ||
* Indent with 4 spaces, no tabs. | ||
* Opening brace on same line as `if` / `else` / `for` / etc. statements. Closing brace on its own line. | ||
* All PRs must have a passing build. | ||
|