allow connect() if this.connected is true

scottn12 · May 9, 2022 · ae2e469 · ae2e469
1 parent ee32abd
commit ae2e469
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/loader/container-loader/src/container.ts b/packages/loader/container-loader/src/container.ts
@@ -956,7 +956,7 @@ export class Container extends EventEmitterWithErrorHandling<IContainerEvents> i
         else if (this._attachState !== AttachState.Attached) {
             throw new UsageError(`The Container is not attached and cannot be connected`);
         }
-        else if (!this.connected) {
+        else {
             // Note: no need to fetch ops as we do it preemptively as part of DeltaManager.attachOpHandler().
             // If there is gap, we will learn about it once connected, but the gap should be small (if any),
             // assuming that connect() is called quickly after initial container boot.

diff --git a/packages/test/test-utils/src/loaderContainerTracker.ts b/packages/test/test-utils/src/loaderContainerTracker.ts
@@ -148,6 +148,7 @@ export class LoaderContainerTracker implements IOpProcessingController {
     /**
      * Make sure all the tracked containers are synchronized.
      * - No isDirty (non-readonly) containers
+     * - No disconnected containers (connectionState === ConnectionState.Disconnected)
      * - No extra clientId in quorum of any container that is not tracked and still opened.
      *      - i.e. no pending Join/Leave message.
      * - No unresolved proposal (minSeqNum \>= lastProposalSeqNum)