[FOLD] Changes transactor uses makeInnerObject(); unit test added

scottschurr · Feb 12, 2024 · e43028c · e43028c
1 parent d1fa0cf
commit e43028c
Show file tree

Hide file tree

Showing 2 changed files with 189 additions and 176 deletions.
diff --git a/src/ripple/app/tx/impl/Change.cpp b/src/ripple/app/tx/impl/Change.cpp
@@ -300,12 +300,12 @@ Change::applyAmendment()
     if (gotMajority)
     {
         // This amendment now has a majority
-        // The following call should use STObject::makeInnerObject
-        newMajorities.push_back(STObject(sfMajority));
+        newMajorities.push_back(
+            STObject::makeInnerObject(sfMajority, view().rules()));
         auto& entry = newMajorities.back();
-        entry.emplace_back(STUInt256(sfAmendment, amendment));
-        entry.emplace_back(STUInt32(
-            sfCloseTime, view().parentCloseTime().time_since_epoch().count()));
+        entry[sfAmendment] = amendment;
+        entry[sfCloseTime] =
+            view().parentCloseTime().time_since_epoch().count();
 
         if (!ctx_.app.getAmendmentTable().isSupported(amendment))
         {