Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing test with ruby 3.2 and 3.3 #516

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

neumayr
Copy link
Contributor

@neumayr neumayr commented Dec 10, 2024

Enhance CI configuration by adding sqlite3 gemfile for Ruby 3.2/3.3 in test matrix

🤷 Sorry, I have no idea why this change has an impact on the old failing ruby tests…

@neumayr neumayr force-pushed the fix-sqlite3-with-ruby-3 branch 3 times, most recently from 346e0f3 to 6e331bb Compare December 10, 2024 11:50
@mitchh456
Copy link
Contributor

Hey @neumayr, thanks for opening this. I don't think your changes here are causing the other failures. I'm seeing the same in another PR. I think we're going to try to merge this and #500 soon, as well as fix those other new failing checks.

@mitchh456
Copy link
Contributor

@neumayr We have merged a PR removing Rubies <= 2.4 from the test matrix. After rebase this PR should fully pass CI.

Enhance CI configuration by adding sqlite3 gemfile for Ruby 3.2/3.3 in test matrix
@neumayr neumayr force-pushed the fix-sqlite3-with-ruby-3 branch from 6e331bb to c443bd5 Compare December 21, 2024 17:37
@neumayr
Copy link
Contributor Author

neumayr commented Dec 21, 2024

@mitchh456 thanks, rebase is done. 🚀

@mitchh456 mitchh456 merged commit 3eeb7a2 into scoutapp:master Dec 23, 2024
15 checks passed
@neumayr neumayr deleted the fix-sqlite3-with-ruby-3 branch December 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants