Add a step to the CI build that fails on warnings in the functional t…

…ests (doesn't fail the build)
scoverage · Aug 28, 2021 · 6d99342 · 6d99342
1 parent 2cc7085
commit 6d99342
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml
@@ -25,3 +25,6 @@ jobs:
       run: chmod +x gradlew
     - name: Build with Gradle
       run: ./gradlew --info --stacktrace check
+    - name: Fail on warning
+      run: ./gradlew --info --stacktrace check --warning-mode=fail -PfailOnWarning
+      continue-on-error: true
diff --git a/build.gradle b/build.gradle
@@ -104,6 +104,8 @@ task functionalTest(type: Test) {
         showStandardStreams = System.env.CI == 'true'
     }
 
+    systemProperty 'failOnWarning', project.hasProperty('failOnWarning')
+
     mustRunAfter crossScalaVersionTest
 }
 check.dependsOn functionalTest
@@ -206,4 +208,4 @@ idea.project.settings {
     taskTriggers {
         beforeBuild fixIdeaPluginClasspath, pluginUnderTestMetadata
     }
-}
+}
diff --git a/src/functionalTest/java/org/scoverage/ScoverageFunctionalTest.java b/src/functionalTest/java/org/scoverage/ScoverageFunctionalTest.java
@@ -127,7 +127,11 @@ private void configureArguments(String... arguments) {
         fullArguments.add("-PjunitVersion=5.3.2");
         fullArguments.add("-PjunitPlatformVersion=1.3.2");
         fullArguments.add("-PscalatestVersion=3.0.8");
-        fullArguments.add("--warning-mode=all");
+        if (Boolean.parseBoolean(System.getProperty("failOnWarning"))) {
+            fullArguments.add("--warning-mode=fail");
+        } else {
+            fullArguments.add("--warning-mode=all");
+        }
         fullArguments.addAll(Arrays.asList(arguments));
 
         runner.withArguments(fullArguments);