Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#87 Fix 'coverage' command for multi-project builds #129

Merged
merged 1 commit into from
Aug 13, 2015

Conversation

RichardBradley
Copy link
Contributor

Fix for #87 -- see comments there

sksamuel added a commit that referenced this pull request Aug 13, 2015
#87 Fix 'coverage' command for multi-project builds
@sksamuel sksamuel merged commit de3830e into scoverage:master Aug 13, 2015
@kamilkloch
Copy link

@RichardBradley, merge does not fix the issue. coverage command in sbt still toggles coverage in one project only. I include sbt console from https://github.com/kamilkloch/scoverage-multi-module:

> show coverageEnabled
[info] three/*:coverageEnabled
[info]  false
[info] two/*:coverageEnabled
[info]  false
[info] one/*:coverageEnabled
[info]  false
[info] scoverage-multi-module/*:coverageEnabled
[info]  false
> coverage
[info] Set current project to scoverage-multi-module (in build file:/home/kamilk/github/scoverage-multi-module/)
> show coverageEnabled
[info] three/*:coverageEnabled
[info]  false
[info] two/*:coverageEnabled
[info]  false
[info] one/*:coverageEnabled
[info]  false
[info] scoverage-multi-module/*:coverageEnabled
[info]  true
> 

@RichardBradley
Copy link
Contributor Author

You're right. There is something wrong with the published 1.3.1 JAR.

If I test with the published JAR from https://dl.bintray.com/sksamuel/sbt-plugins/ then I get the same results as you.

If I build 1.3.1 locally (from commit "de3830e63") and do "sbt publishLocal", then I get the expected results:

$ sbt
[info] Loading project definition from \scoverage-multi-module\project
[info] Updating {/scoverage-multi-module/project/}scoverage-multi-module-build...
[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[info] Done updating.
[info] Set current project to scoverage-multi-module (in build file:/scoverage-multi-module/)
> coverage
[info] Set current project to scoverage-multi-module (in build file:/scoverage-multi-module/)
> show coverageEnabled
[info] three/*:coverageEnabled
[info]  true
[info] two/*:coverageEnabled
[info]  true
[info] one/*:coverageEnabled
[info]  true
[info] scoverage-multi-module/*:coverageEnabled
[info]  true

@sksamuel - do you have any idea how the wrong JAR got published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants