Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on jdk 8 and 11 #340

Merged
merged 1 commit into from
May 2, 2021
Merged

Test on jdk 8 and 11 #340

merged 1 commit into from
May 2, 2021

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented May 2, 2021

No description provided.

@SethTisue
Copy link

SethTisue commented May 2, 2021

what benefit do you want from using setup-scala instead of setup-java?

setup-scala gives you sbt-extras instead of the official launcher, is a reason to be skeptical of it (IMO). in general, setup-scala seems like an unnecessary dependency to me

@ckipp01
Copy link
Member Author

ckipp01 commented May 2, 2021

what benefit do you want from using setup-scala instead of setup-java?

setup-scala gives you sbt-extras instead of the official launcher, is a reason to be skeptical of it (IMO). in general, setup-scala seems like an unnecessary dependency to me

Honestly, I don't have a good reason. setup-scala is just what we use in all of the scala-meta projects. So some of this was a shameless copy over.

setup-scala gives you sbt-extras instead of the official launcher, is a reason to be skeptical of it (IMO). in general, setup-scala seems like an unnecessary dependency to me

Good point. Let me stick setup-java back in here and see if I hit on anything unexpected. Total aside, but I've actually never asked why setup-scala doesn't use the official launcher. As it's probably been said many times before... I wish there was only 1.

Also both CI and release to setup-java
@ckipp01 ckipp01 merged commit 93edf00 into scoverage:main May 2, 2021
@ckipp01 ckipp01 deleted the ci branch May 2, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants