-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh excluding packages and files #443
Conversation
if (sys.props.get("plugin.version").exists(_.endsWith("-SNAPSHOT"))) | ||
Seq(Resolver.sonatypeRepo("snapshots")) | ||
else Seq.empty | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a test for excludedFiles
.
if (sys.props.get("plugin.version").exists(_.endsWith("-SNAPSHOT"))) | ||
Seq(Resolver.sonatypeRepo("snapshots")) | ||
else Seq.empty | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding test for excludedPackages
.
@@ -7,4 +7,4 @@ | |||
> coverageOff | |||
> test | |||
# There should be no scoverage-data directory | |||
-$ exists target/scala-2.12/scoverage-data | |||
-$ exists target/scala-2.13/scoverage-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing typo, Making test work (again).
# There should be no directory for the excluded files | ||
#-$ exists target/scala-3.2.0-RC1/scoverage-report/two | ||
# But right now there is, because Scala3 does not support excluding files | ||
$ exists target/scala-3.2.0-RC1/scoverage-report/two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to show/document that excluding files (and packages) is not working right now.
Aiming to make this work (somehow).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the additional tests and documentation @rolandtritsch. LGTM
Hi @ckipp01,
here is the second PR on refreshing the excluded packages and files functionality.