Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert descendant combinator change #63

Merged
merged 1 commit into from
Oct 16, 2016
Merged

Revert descendant combinator change #63

merged 1 commit into from
Oct 16, 2016

Conversation

redapple
Copy link
Contributor

This reverts the change to xpath_descendant_combinator from d86287d so as to keep backwards compatiblity with cssselect-dependent libraries like parsel (see #61 (comment) and subsequent comments)

/descendant:: and /descendant-or-self::*/ are essentially equivalent in practice for the translation when only elements are involved. But for custom pseudo-elements like parsel does with ::text and ::attr(name), which need a bit of hacking of the translated path, it's probably safer to keep the "long" version.

/cc @kmike

@codecov-io
Copy link

codecov-io commented Sep 12, 2016

Current coverage is 95.02% (diff: 100%)

Merging #63 into master will not change coverage

@@             master        #63   diff @@
==========================================
  Files             3          3          
  Lines           703        703          
  Methods           0          0          
  Messages          0          0          
  Branches        114        114          
==========================================
  Hits            668        668          
  Misses           20         20          
  Partials         15         15          

Powered by Codecov. Last update 653bcfb...e84f1b5

@kmike kmike merged commit 8f07472 into scrapy:master Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants