Revert descendant combinator change #63
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the change to
xpath_descendant_combinator
from d86287d so as to keep backwards compatiblity with cssselect-dependent libraries like parsel (see #61 (comment) and subsequent comments)/descendant::
and/descendant-or-self::*/
are essentially equivalent in practice for the translation when only elements are involved. But for custom pseudo-elements like parsel does with::text
and::attr(name)
, which need a bit of hacking of the translated path, it's probably safer to keep the "long" version./cc @kmike