Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse |ident as ident. No longer an error. #88

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Parse |ident as ident. No longer an error. #88

merged 1 commit into from
Aug 1, 2019

Conversation

sjp
Copy link
Contributor

@sjp sjp commented Jul 11, 2019

Continuation of #21.

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #88 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   95.14%   95.16%   +0.02%     
==========================================
  Files           2        2              
  Lines         700      703       +3     
  Branches      115      116       +1     
==========================================
+ Hits          666      669       +3     
  Misses         19       19              
  Partials       15       15
Impacted Files Coverage Δ
cssselect/parser.py 95.37% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99bc54c...81c8dab. Read the comment docs.

@sjp
Copy link
Contributor Author

sjp commented Jul 17, 2019

Hi, is there anything more needed to merge this into master?

@Gallaecio
Copy link
Member

A second approval by a core team member. It can take a while, though, so please be patient.

@sjp
Copy link
Contributor Author

sjp commented Jul 17, 2019

No worries. Thanks.

@kmike kmike merged commit 02ec77c into scrapy:master Aug 1, 2019
@kmike
Copy link
Member

kmike commented Aug 1, 2019

Thanks @sjp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants