exception handling was hiding original exception

scrapy · Apr 22, 2016 · bd72121 · bd72121
1 parent 04e6e14
commit bd72121
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/parsel/selector.py b/parsel/selector.py
@@ -2,6 +2,8 @@
 XPath selectors based on lxml
 """
 
+import sys
+
 import six
 from lxml import etree
 
@@ -175,9 +177,10 @@ def xpath(self, query):
         try:
             result = xpathev(query, namespaces=self.namespaces,
                              smart_strings=self._lxml_smart_strings)
-        except etree.XPathError:
-            msg = u"Invalid XPath: %s" % query
-            raise ValueError(msg if six.PY3 else msg.encode("unicode_escape"))
+        except etree.XPathError as exc:
+            msg = u"XPath error: %s in %s" % (exc, query)
+            msg = msg if six.PY3 else msg.encode('unicode_escape')
+            six.reraise(ValueError, ValueError(msg), sys.exc_info()[2])
 
         if type(result) is not list:
             result = [result]

diff --git a/tox.ini b/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py27, py33, py34
+envlist = py27, py33, py34, py35
 
 [testenv]
 deps =