-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating classifiers in setup.py #19
Conversation
Current coverage is
|
updating classifiers in setup.py
Can someone please run |
@kmike we'll release a 1.0.1 soon, do you think we should still register it for 1.0.0? |
I just wanted to mention that if the only reason to release 1.0.1 is to get classifiers updated then one can use |
why not going trough the usual flow of releasing a patch version? it seems natural to me and it doesn't have any disadvantages |
@kmike well, I fixed a typo in HISTORY and I'll also add docstrings to csstranslator.py to help justify the release. =D |
One release more means users have to check what is changed one more time, download the package one more time and read one more changelog entry (irrelevant for the user). Not a big deal, but still.
A docstring is a code change, so it can justify a release :) |
I think it is up to the guy in control of releases, although we will need an emoji for 🚲shedding :) |
My point is that if we know nothing is changed from user's point of view we shouldn't do a release. +1 to find a right emoji :) |
🚲 ⛺ ? |
👍 |
nice one :) |
Hey fellows,
This fixes the pre-alpha classifier (see #18) and also add
Topic :: Text Processing :: Markup
.We can consider it stable since v1.0, Scrapy is even depending on the current API already.
Also, maybe we could add the more specific
Topic :: Text Processing :: Markup :: HTML
andTopic :: Text Processing :: Markup :: XML
too (see list of classifiers here).What do you think?
Thanks!