Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: enable py3.5, disable pypy #37

Merged
merged 1 commit into from
Mar 22, 2016
Merged

Travis: enable py3.5, disable pypy #37

merged 1 commit into from
Mar 22, 2016

Conversation

eliasdorneles
Copy link
Member

Hey folks!
So it turns out lxml never really worked in pypy, so we should disable it from tests -- see issue #35

@codecov-io
Copy link

Current coverage is 96.90%

Merging #37 into master will decrease coverage by -3.10% as of 019d991

Powered by Codecov. Updated on successful CI builds.

@dangra
Copy link
Member

dangra commented Mar 22, 2016

pypy 5.0.1 seems to work:

$ tox -e pypy
GLOB sdist-make: /Users/daniel/src/parsel/setup.py
pypy create: /Users/daniel/src/parsel/.tox/pypy
pypy installdeps: -r/Users/daniel/src/parsel/tests/requirements.txt, .
pypy inst: /Users/daniel/src/parsel/.tox/dist/parsel-1.0.1.zip
pypy installed: You are using pip version 8.0.2, however version 8.1.1 is available.,You should consider upgrading via the 'pip install --upgrade pip' command.,cffi==1.5.2,coverage==4.0.3,cssselect==0.9.1,greenlet==0.4.9,lxml==3.6.0,parsel==1.0.1,py==1.4.31,pytest==2.9.1,pytest-cov==2.2.1,readline==6.2.4.1,six==1.10.0,w3lib==1.13.0,wheel==0.26.0
pypy runtests: PYTHONHASHSEED='3193435006'
pypy runtests: commands[0] | py.test --cov=parsel --cov-report= parsel tests
======================================== test session starts ========================================
platform darwin -- Python 2.7.10[pypy-5.0.1-final], pytest-2.9.1, py-1.4.31, pluggy-0.3.1
rootdir: /Users/daniel/src/parsel, inifile: pytest.ini
plugins: cov-2.2.1
collected 53 items

parsel/utils.py ..
tests/test_selector.py ..................s......................
tests/test_selector_csstranslator.py ..........

=============================== 52 passed, 1 skipped in 1.25 seconds ================================
______________________________________________ summary ______________________________________________
  pypy: commands succeeded
  congratulations :)

@dangra
Copy link
Member

dangra commented Mar 22, 2016

I guess we can wait for travis-ci to update pypy on its base image

dangra added a commit that referenced this pull request Mar 22, 2016
Travis: enable py3.5, disable pypy
@dangra dangra merged commit 1d19b4a into master Mar 22, 2016
@dangra dangra deleted the disable-pypy-tests branch March 22, 2016 03:24
@redapple
Copy link
Contributor

redapple commented Jul 6, 2016

One can install newer PyPy #44 (trick from travis-ci/travis-ci#5027 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants