Support CircleCI to test Scrapyd as a service #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=========================================
Coverage ? 68.66%
=========================================
Files ? 17
Lines ? 868
Branches ? 104
=========================================
Hits ? 596
Misses ? 241
Partials ? 31 Continue to review full report at Codecov.
|
Merged
|
I don't have admin access to the repo |
jpmckinney
added
the
pr: replaced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic test passed in https://app.circleci.com/pipelines/github/my8100/scrapyd-CircleCI
@Digenis
Need the repo admin to enable CircleCI first so that more tests could be added.
https://app.circleci.com/projects/project-dashboard/github/scrapy/