Client return types #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Ryang-21
commented
Feb 27, 2024
•
Ryang-21
commented
- Changed client function return type to the xdr of the operation
- Made client parsers accessible
- exported contract errors and nativeToScVal
- updated contract specs
mootz12
approved these changes
Feb 27, 2024
src/index.ts
Outdated
| @@ -1,7 +1,8 @@ | |||
| export * from "./governor.js"; | |||
| export * from "./votes.js"; | |||
| export * from "./contract_result.js"; | |||
|
|
|||
| export * from "./contract_error.js"; | |||
| export { nativeToScVal } from "@stellar/stellar-sdk"; | |||
There was a problem hiding this comment.
am OK with letting this workaround go by, but part of me thinks we should try transforming the incoming Array<any> into:
arg: string[]
fn {
real_arg = arg.map // map string to xdr.ScVal
}
That way users of the SDK have a clear parameter type (we probs need to add a comment explaining what kind of string it is)
mootz12
approved these changes
Feb 27, 2024
Comment on lines
+172
to
+174
| else { | ||
| result.result = new Ok(undefined as T); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.