Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libzkp): replace tag with rev for halo2curves in libzkp #629

Merged

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Jul 8, 2023

Purpose or design rationale of this PR

Related discussion - https://scrollco.slack.com/archives/C02PP3NNDC5/p1688757344316329
Or wait for scroll-tech/halo2#51 (than update).

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Thegaram
Thegaram previously approved these changes Jul 8, 2023
common/libzkp/impl/Cargo.toml Show resolved Hide resolved
common/libzkp/impl/Cargo.lock Outdated Show resolved Hide resolved
Thegaram
Thegaram previously approved these changes Jul 9, 2023
@silathdiir
Copy link
Contributor Author

@Thegaram Sorry, I missed to do a full search for scroll-zkevm in scroll, just update to rename all scroll-zkevm to scroll-prover in commit 148d070.

Thegaram
Thegaram previously approved these changes Jul 9, 2023
@silathdiir silathdiir requested a review from 0xmountaintop July 10, 2023 02:42
Copy link
Contributor

@Lawliet-Chan Lawliet-Chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can test it by using https://github.com/scroll-tech/test_zkp on GPU machine

0xmountaintop
0xmountaintop previously approved these changes Jul 10, 2023
@0xmountaintop 0xmountaintop changed the title Replace tag with rev for halo2curves in libzkp fix(libzkp): replace tag with rev for halo2curves in libzkp Jul 10, 2023
@0xmountaintop 0xmountaintop dismissed stale reviews from Thegaram and themself via a0fb6bd July 10, 2023 04:23
@0xmountaintop 0xmountaintop merged commit 1b62c06 into develop Jul 10, 2023
@0xmountaintop 0xmountaintop deleted the replace-scroll-zkevm-with-scroll-prver-in-libzkp branch July 10, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants