Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test part of the build and release workflow. Run tests on all branches. #224

Closed
wants to merge 3 commits into from

Conversation

bernheder
Copy link

I think the test job should be part of both the build and release workflows, as the package should only be built and released if it functions correctly.

Furthermore, since the test job is then part of the build/release process and consistently runs on the same trigger as the build workflow (push/pull requests to the main branch), it can either be removed or, in this case, modified to run in different scenarios (I would suggest running tests on all branches).

@grst
Copy link
Collaborator

grst commented Nov 28, 2023

I don't think we need this...

  • tests already run on all branches for which a pull request exists (and a pull request is the only way to get something in the main branch)
  • anything in the main branch needed to pass the tests to get in, so we don't need to rerun them on release.

@grst grst closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants