-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc cleanup #2983
Merged
Merged
Doc cleanup #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
==========================================
- Coverage 75.53% 73.19% -2.35%
==========================================
Files 117 117
Lines 12950 12914 -36
==========================================
- Hits 9782 9452 -330
- Misses 3168 3462 +294 |
flying-sheep
force-pushed
the
doc-cleanup
branch
from
April 22, 2024 13:21
e2161fd
to
3a597a9
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Apr 22, 2024
flying-sheep
added a commit
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Philipp A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing bibtex formatter from my review in #2901. Since this PR is necessary to productively work with the bibliography without making a mess, and y’all are on a hackathon, I’ll merge it without review.
Content
Replace frail line based inclusions like
:end-line: 32
with markers. If someone destroys a marker, the doc build will fail instead of containing a garbled mess.Moves the flit-centric dev docs to non-opinionated tooling
Since there are no functional bib formatters that run within pre-commit (See Extend Sect. Related Programs by 'betterbib', 'python-bibtexparser', 'BibDesk' and 'ebib' ge-ne/bibtool#58), we’re going to have to live with using our own. For that purpose, I took the last open source version of
betterbib
and trimmed it down a bitOnce there’s something better that we don’t have to maintain, we should use that
Companion PR: scverse/scanpy-tutorials#103