Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Pyro cell2location #930

Closed
wants to merge 171 commits into from
Closed

Conversation

vitkl
Copy link
Contributor

@vitkl vitkl commented Feb 16, 2021

No description provided.

Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a lot of comments but I don't think the model is that far off from being ready to go.

scvi/external/cell2location/_model.py Outdated Show resolved Hide resolved
scvi/external/cell2location/_model.py Outdated Show resolved Hide resolved
scvi/external/cell2location/_model.py Outdated Show resolved Hide resolved
scvi/external/cell2location/_model.py Outdated Show resolved Hide resolved
scvi/external/cell2location/_model.py Outdated Show resolved Hide resolved
scvi/external/cell2location/_module.py Outdated Show resolved Hide resolved
scvi/external/cell2location/_module.py Outdated Show resolved Hide resolved
scvi/external/cell2location/_module.py Outdated Show resolved Hide resolved
scvi/external/cell2location/_module.py Outdated Show resolved Hide resolved
scvi/external/cell2location/_module.py Outdated Show resolved Hide resolved
@vitkl
Copy link
Contributor Author

vitkl commented Feb 18, 2021

Seems like a lot of comments but I don't think the model is that far off from being ready to go.

Thanks a lot for the feedback! It will take a while to address (because I also want to keep things consistent with main cell2location pymc3 repo) and some of it I think needs discussion - but good to have feedback!

@vitkl vitkl changed the title Pyro cell2location [WIP] Pyro cell2location Mar 8, 2021
@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #930 (7808c9a) into master (98f466a) will decrease coverage by 14.07%.
The diff coverage is 12.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #930       +/-   ##
===========================================
- Coverage   90.64%   76.57%   -14.08%     
===========================================
  Files          91      103       +12     
  Lines        6908     8434     +1526     
===========================================
+ Hits         6262     6458      +196     
- Misses        646     1976     +1330     
Impacted Files Coverage Δ
...external/cell2location/_cell2location_v2_module.py 0.00% <0.00%> (ø)
...ation/_cell2location_v3_no_factorisation_module.py 0.00% <0.00%> (ø)
...al/cell2location/_cell2location_v3_no_mg_module.py 0.00% <0.00%> (ø)
...external/cell2location/_cell2location_v4_module.py 0.00% <0.00%> (ø)
...cvi/external/cell2location/_reference_module_v2.py 0.00% <0.00%> (ø)
...external/cell2location/_cell2location_v3_module.py 15.57% <15.57%> (ø)
scvi/external/cell2location/autoguide.py 20.00% <20.00%> (ø)
scvi/external/cell2location/_reference_module.py 21.07% <21.07%> (ø)
scvi/external/cell2location/_base.py 23.07% <23.07%> (ø)
...external/cell2location/_cell2location_v1_module.py 24.40% <24.40%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f466a...7808c9a. Read the comment docs.

@vitkl vitkl closed this Aug 23, 2021
@vitkl vitkl reopened this Aug 23, 2021
@vitkl vitkl closed this Aug 23, 2021
@vitkl
Copy link
Contributor Author

vitkl commented Aug 23, 2021

Moved the model to https://github.com/BayraktarLab/cell2location/tree/master/cell2location/models and closing this PR

(accidentally closed and reopened a few times)

@vitkl vitkl reopened this Aug 23, 2021
@vitkl vitkl closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants