add io test #21
Merged
add io test #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 15 15
Lines 667 667
=====================================
Misses 667 667
Flags with carried forward coverage won't be shown. Click here to find out more. |
updates: - [github.com/asottile/yesqa: v1.3.0 → v1.4.0](asottile/yesqa@v1.3.0...v1.4.0) - [github.com/PyCQA/flake8: 5.0.1 → 5.0.4](PyCQA/flake8@5.0.1...5.0.4) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
@LucaMarconato feel free to merge in your branch anytime you're ready |
ivirshup
approved these changes
Aug 18, 2022
|
I believe @LucaMarconato merged this in #22 already, can we close it? thanks for feedback, good point we can remove private/public |
|
Can we merge it instead? I would much rather have the test on main. |
|
Yes we can merge. I added an extra step to the roundtrip (writing back to disk and checking the written output bytewise) and this triggers a nasty bug. Gonna open a issue later, but we meanwhile we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.